This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[OCF client] remove the update event from ClientResource. #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ination.destination to Destination.endpoint. Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
|
|
||
| <a name="resource"></a> | ||
| ### 1.4. The `Resource` dictionary | ||
| ### 1.4. The `Resource` dictionarydestination |
|
What happens when you want to stop observing? How do you remove the callback? |
|
I was thinking that the callback might return a special value. That's what the lower level callback does: OTOH, our high-level solution so far has been to have an entity external to the callback add/remove the callback. This would allow the callback to be free of code wherein it decides whether to stay attached or not. |
Contributor
Author
|
Based on the OCF Core spec, I expect that making a retrieve request without providing an observer (i.e. the observe flag) will stop observing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, change Destination.destination to Destination.endpoint.
Reason for change: when multiple endpoints are supported with a Resource, (update) event observation would need a parameter for specifying the endpoint. This is not possible with events. Hence we need to remove the convenience feature for observing resource updates with an event listener. From now on the only way to observe resource updates is by specifying a listener to the
retrieve()method, i.e. follow the CoAP observe pattern (make a retrieve request with the 'observe' flag turned on).Signed-off-by: Zoltan Kis zoltan.kis@intel.com